Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards: multiple enhancements #598

Merged
merged 39 commits into from
Nov 21, 2019

Conversation

veggiematts
Copy link
Contributor

This PR is a superset of the following PRs:

If the changes provided by all previous PRs are accepted, I'd rather see this branch being merged, avoiding inter-PRs merge issues.

Before:
before

After:
after

 - Add an option to display all the data.
…ds' dropdown lists

 - Fix limits for export
 - Fix export parameters summary
…ds' dropdown lists

 - Fix select names and ids to be both compatible with xhr and post
…ds' dropdown lists

 - Fix cost details for yearly dashboard
 - Add classes for styling totals and subtotals
 - Add cell border
 - Fix striping and hovering
 - Fix total and subtotal classes
 - Add styling to total and subtotal rows
 - Add underline to filtering headers
@veggiematts veggiematts added the enhancement This is an enhancement (not a bug) label Aug 26, 2019
@poacherone
Copy link
Collaborator

Tested this PR extensively and the new enhancements works as intended. But as Stockholm University Library has sponsored these developments, it is probably good to have someone else test it as well.

@veggiematts
Copy link
Contributor Author

As approved by the SC, I'm merging this.

@veggiematts veggiematts merged commit 6c249a0 into coral-erm:development Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement (not a bug)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants