Issue 365: Opening modules in the same or a new window is configurable. #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and switching modules through the top menu works as intended. One further question is how to handle the "Helpful links" panel to the right of the page? I would argue that these should also respect the configuration. And there are also a few other places (mostly in resources) that link between modules, what about those? (Locally we have it set today that only links to external resources/pages open in a new window, all other are within the same window.) But this is a great starting point! |
In common/configuration.ini: [settings] open_new_windows = Y/N By default, the links are opened in a new window/tab.
veggiematts
force-pushed
the
Issue_365_new_window
branch
from
4aefad5 to
13f957d
Compare
|
Rebased on devel branch. Since it does not change the existing behavior when unconfigured, I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: issue #365 : Switching module should not open an new windows
In common/configuration.ini:
By default, the links are opened in a new window/tab.