Contacts appear blank when reporting issues if name is empty #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tact name is undefined
…ed reports per COUNTER Release 5 (4.3.2 and 4.4.2)
|
Tested in-house successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by a SirsiDynix customer: when reporting a new issue for a resource or organization, contacts are shown as blank values when the contact has no name. It would be preferable to show the email address when there is no name.
These are relatively simple changes that ought not adversely affect anyone who is content with the current functionality.
It's perhaps a moot point whether it's good practice to enter contacts without a name although I note the name field is not strictly required.
+++
Also:
YOP should not be included in TR_J* reports per the spec (4.3.2) and backed up by examples from several different sources. A few other changes made to item report layouts based on spec (4.4.2). Note there are still some fields missing from the item report layouts per the spec although I have never seen these in any examples so reluctant to make any changes at this point.