Update externalLoginSubmitForm.js #678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Usage module: The modal "getLoginForm" will not open. Usage module Home, click on a Platform entry, click on the tab Logins, click "add new login" There will be a waiting image, but the modal is not opening. The problem was two unclosed parentheses in the javascript file.
|
This fix should really go into coral-erm:development initially. |
|
I have tested the fix in any case and can approve merging into coral-erm:development. Thank you for this contribution. |
|
Thanks Andy! / Maria |
|
Opened #699 to merge these changes into development branch. |
andyp-uk
added a commit
to Sirsidynix/coral
that referenced
this pull request
Mar 21, 2022
In Usage Statistics, the getLoginForm will not open. Fix originally proposed under coral-erm#678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Usage module: The modal "getLoginForm" will not open.
Usage module Home, click on a Platform entry, click on the tab Logins, click "add new login" There will be a waiting image, but the modal is not opening.
The problem was two unclosed parentheses in the javascript file.