string 'null' sent instead of null value caused data saving failure #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On licensing upload form, if no effective date is entered, this induce a msql error similar problem on management module
gmcharlt
approved these changes
Jun 16, 2022
There was a problem hiding this comment.
Change works as advertised. In particular, it allows me to upload licenses with empty effective dates.
On the management document upload side, I wasn't able to find a way to trigger an upload with an empty effective date (as the form defaults that date to today's date), but if that branch of execution ever gets reached, the proposed change would make it do the right thing.
spaceisntsyntax
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On licensing upload form, if no effective date is entered, this induce a msql error
similar problem on management module