Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add platform parameter to SUSHI Services in Usage Module #701

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Add platform parameter to SUSHI Services in Usage Module #701

merged 1 commit into from
Jun 17, 2022

Conversation

kmcarnes
Copy link
Contributor

No description provided.

@andyp-uk andyp-uk self-requested a review April 27, 2022 15:33
@andyp-uk andyp-uk mentioned this pull request Jun 16, 2022
Closed
@gmcharlt
Copy link

I have tested the change and confirm that

  • it's properly saving the platform in the SUSHI service definition
  • it's allowing me to successfully fetch reports from Loeb Classical Library (which requires a platform string)

@andyp-uk andyp-uk merged commit f6fb975 into coral-erm:development Jun 17, 2022
@andyp-uk andyp-uk removed their request for review April 23, 2024 11:13
@andyp-uk andyp-uk added the enhancement This is an enhancement (not a bug) label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement This is an enhancement (not a bug)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmcarnes @gmcharlt @andyp-uk