Erm 63 modern jquery update with php8 fixes wip #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Rylander <mrylander@gmail.com>
The scripted CSV export event listener and the Resource->Admin removeData binding was happening too early, before the XHR-loaded HTML was available. This places the binding requests right next to the elements that need them, so timing won't be an issue going forward. Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
…JS event listener binding closer to the intended elements Signed-off-by: Mike Rylander <mrylander@gmail.com>
randallrupper
merged commit 8e6495a
into
coral-erm:ERM-63-modern-jquery-update-with-php8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.