Do not process URLs passed directly from users #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUSHI statistics can be retreived from a stored URL, but those are downloaded locally before being processed by the uploadComplete.php script. Because of that, we can simply refuse to load data from URLs using the (local) utf8_fopen_read function, which is only used to load server-local files into memory for processing. Signed-off-by: Mike Rylander <mrylander@gmail.com>
|
Smoke tested and no problems found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUSHI statistics can be retreived from a stored URL, but those are downloaded locally before being processed by the uploadComplete.php script. Because of that, we can simply refuse to load data from URLs using the (local) utf8_fopen_read function, which is only used to load server-local files into memory for processing.