Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern jQuery update with support for PHP 8 #759

Merged
merged 76 commits into from
Apr 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
9b2ebd5
PHP 8 Compatibility
aniqaamir Nov 8, 2021
e67a370
Update license module jquery
JohnYorio Aug 5, 2021
de7ad4f
Convert the Resources module to modern jquery
JohnYorio Nov 29, 2021
a3b8a44
Move the Usage module to modern jquery
spaceisntsyntax Oct 12, 2022
6e112e8
Move the Orgs module to modern jquery
spaceisntsyntax Oct 12, 2022
36704ce
Move the Management module to modern jquery
spaceisntsyntax Oct 12, 2022
bb52d65
Clean up some cruft in the resources and licensing module jquery move
spaceisntsyntax Oct 12, 2022
a6434cc
Move the remaining few interfaces to modern jquery
spaceisntsyntax Oct 12, 2022
ee970dd
Remove old jquery and thickbox.sj implementations
spaceisntsyntax Oct 12, 2022
9bd0a30
ERM-63 Fixing a syntax problem in the DynamicObject files
Oct 27, 2022
39d040f
Added quotes around associative array key -- PHP sytax issue
spaceisntsyntax May 12, 2023
e55e1c8
Address JS event listener binding timing issues
spaceisntsyntax May 12, 2023
bda101e
Convert Resource -> ACQ thickbox modals to the new style
spaceisntsyntax May 15, 2023
de07ba9
Final transition from thickbox to jquery-ui dialog; Moving some more …
spaceisntsyntax May 17, 2023
8e6495a
Merge pull request #725 from EquinoxOpenLibraryInitiative/ERM-63-mode…
May 22, 2023
f2aa599
Another fix for event listener attachment timing
spaceisntsyntax May 24, 2023
0f7fe7a
Workflow setup UI fixes found in JQuery/PHP8 testing
spaceisntsyntax May 24, 2023
7df6801
Fix PHP8 strictness issue on class inheritance (function parameters m…
spaceisntsyntax May 24, 2023
0a5c8a9
Implement jq-ui-dialog version of Resource issue and downtime management
spaceisntsyntax May 24, 2023
e4b4c06
Move Organization module to modern mysql date style (null rather than…
spaceisntsyntax May 25, 2023
2b32370
Adjust styling of the new jquery-UI components to avoid scrolling and…
spaceisntsyntax Jun 13, 2023
f24ecbe
Merge pull request #727 from EquinoxOpenLibraryInitiative/ERM-63-mode…
Jun 15, 2023
d763b29
JQ syntax changed for checkbox inspection, updating to match
spaceisntsyntax Jul 11, 2023
4217e9b
ERM-103 Fix arrows not reordering. Listeners attached after html crea…
Sep 1, 2023
fe977cf
Merge pull request #730 from coral-erm/bugfix/ERM-103-reorder-workflo…
Sep 1, 2023
ace77cc
ERM-103 Fix arrows not reordering. Listeners attached after html crea…
Sep 7, 2023
e155149
Merge branch 'ERM-63-modern-jquery-update-with-php8' into bugfix/ERM-…
Sep 12, 2023
ef1cf64
Merge pull request #731 from coral-erm/bugfix/ERM-103-reorder-workflo…
Sep 12, 2023
d97e3a3
Merge pull request #732 from EquinoxOpenLibraryInitiative/ERM-63-mode…
Sep 26, 2023
be10ec7
Removed unused search parameters #ERM-104
sumbria Oct 11, 2023
1ecd008
Update .gitignore
andyp-uk Oct 11, 2023
bcc27dc
Fixed resources pagination & records limit issue #ERM-105
sumbria Oct 12, 2023
83e1278
Merge pull request #733 from coral-erm/ERM-104
andyp-uk Oct 17, 2023
a01403d
Merge pull request #734 from coral-erm/ERM-105
andyp-uk Oct 17, 2023
503d6ea
Fixed report new issue submission issue ERM-108
sumbria Dec 6, 2023
bd237ce
Fixed reporting downtime issue ERM-107
sumbria Dec 12, 2023
4b8e25c
Fixed blank SUSHI service modal ERM-109
sumbria Feb 12, 2024
70d680a
Fixed SUSHI Import ERM-110
sumbria Feb 14, 2024
a11f7bc
Merge pull request #741 from coral-erm/ERM-110
andyp-uk Feb 15, 2024
faa5d09
Sushi import bugs fixing ERM-110
sumbria Feb 22, 2024
94be658
Fixed ONIX-PL Import issue ERM-106
sumbria Feb 26, 2024
102c92f
Merge pull request #742 from coral-erm/ERM-106
andyp-uk Feb 26, 2024
11136de
Fixed downtime links ERM-107
sumbria Feb 26, 2024
591e318
Fixed bugs when reporting an issue ERM-108
sumbria Feb 26, 2024
6d288d5
Fixed logins tab loading issue in usage module ERM-111
sumbria Feb 26, 2024
af90a78
Merge pull request #743 from coral-erm/ERM-107
andyp-uk Feb 26, 2024
d816876
Merge pull request #744 from coral-erm/ERM-108
andyp-uk Feb 26, 2024
b892026
Merge pull request #745 from coral-erm/ERM-111
andyp-uk Feb 26, 2024
d50ce54
Update URL to COUNTER Registry
andyp-uk Feb 29, 2024
38358d7
remove duplicate javascript includes from resource.php
jsavell Mar 1, 2024
f109dc0
restore i18n keys for datepicker
jsavell Mar 1, 2024
a193a5e
switch to latest version of datepicker plugin
jsavell Mar 1, 2024
082177d
Fixed Askews and Holts SUSHI import issue #ERM-119
sumbria Mar 18, 2024
d1cb163
Fixed edit cataloging details issue #ERM-74
sumbria Mar 18, 2024
67411eb
Merge pull request #751 from coral-erm/ERM-74
andyp-uk Mar 18, 2024
4f6bb4f
Fixed characters encoding issue ERM-116
sumbria Mar 20, 2024
75c50be
Merge pull request #752 from coral-erm/ERM-116
andyp-uk Mar 20, 2024
cc81d13
management - re-load datepickers after modal instantiation
jsavell Mar 21, 2024
308dee4
Fixed utf8 encoding issue ERM-116
sumbria Mar 21, 2024
e5c3103
Merge pull request #754 from coral-erm/ERM-116
andyp-uk Mar 21, 2024
1df9654
Fixed jquery issues on issues tab ERM-107
sumbria Mar 21, 2024
2ac68ff
Merge pull request #755 from coral-erm/ERM-107
andyp-uk Mar 22, 2024
093c001
Do not process URLs passed directly from users
spaceisntsyntax Mar 22, 2024
001c256
Merge pull request #756 from EquinoxOpenLibraryInitiative/disallow_re…
andyp-uk Mar 22, 2024
77c438c
Added in progress statuses option in admin ERM-117
sumbria Mar 27, 2024
c287ae1
Get license in progress dynamically ERM-117
sumbria Mar 27, 2024
7afd2c4
Code optimization ERM-117
sumbria Mar 27, 2024
926fb6f
Merge pull request #757 from coral-erm/ERM-117
andyp-uk Mar 27, 2024
d99e36e
Fixed resolve downtime button issue
sumbria Apr 3, 2024
c526250
Fixed blank export issues
sumbria Apr 3, 2024
64db1c6
Fixed export issues for organizations
sumbria Apr 3, 2024
6f9e1c2
Reverted export code changes
sumbria Apr 4, 2024
ef17f65
Fixed export issues
sumbria Apr 4, 2024
0045b74
Merge pull request #758 from coral-erm/ERM-117
andyp-uk Apr 4, 2024
169d9aa
Merge pull request #749 from TAMULib/date-picker-update
andyp-uk Apr 4, 2024
8bdd443
Merge pull request #753 from TAMULib/management-datepicker-fix
andyp-uk Apr 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions auth/admin.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@
<link rel="SHORTCUT ICON" href="images/favicon.ico" />
<link rel="stylesheet" href="//maxcdn.bootstrapcdn.com/font-awesome/4.3.0/css/font-awesome.min.css">
<link href='https://fonts.googleapis.com/css?family=Open+Sans:100,400,300,600,700' rel='stylesheet' type='text/css'>
<script type="text/javascript" src="../js/plugins/jquery-1.8.0.js"></script>
<script type="text/javascript" src="js/plugins/thickbox.js"></script>
<script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jquery/3.6.0/jquery.min.js"></script>
<link rel="stylesheet" href="https://ajax.googleapis.com/ajax/libs/jqueryui/1.12.1/themes/smoothness/jquery-ui.css"></script>
<script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jqueryui/1.12.1/jquery-ui.min.js"></script>
<script type="text/javascript" src="js/common.js"></script>
<script type="text/javascript" src="../js/plugins/Gettext.js"></script>
<?php
Expand Down
1 change: 0 additions & 1 deletion auth/admin/classes/common/DynamicObject.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
**************************************************************************************************************************
*/


class DynamicObject extends Base_Object {

protected $properties = array();
Expand Down
2 changes: 1 addition & 1 deletion auth/ajax_forms.php
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
<table class='noBorderTable' style='width:125px;'>
<tr>
<td style='text-align:left;'><input type='button' value='<?php echo _("submit");?>' id ='submitUser' class='submitButton' /></td>
<td style='text-align:right;'><input type='button' value='<?php echo _("cancel");?>' onclick="window.parent.tb_remove(); return false;" class='submitButton' /></td>
<td style='text-align:right;'><input type='button' value='<?php echo _("cancel");?>' onclick="myCloseDialog(); return false;" class='submitButton' /></td>
</tr>
</table>

Expand Down
6 changes: 3 additions & 3 deletions auth/ajax_htmldata.php
Original file line number Diff line number Diff line change
Expand Up @@ -50,18 +50,18 @@
echo "<tr>";
echo "<td>" . $userArray['loginID'] . "</td>";
echo "<td>" . $isAdmin . "</td>";
echo "<td><a href='ajax_forms.php?action=getAdminUserUpdateForm&loginID=" . $userArray['loginID'] . "&height=230&width=315&modal=true' class='thickbox'><img src='images/edit.gif' alt='"._("edit password or admin status")."' title='"._("edit password or admin status")."'></a></td>";
echo "<td><a href='javascript:void(0)' onclick='javascript:myDialog(\"ajax_forms.php?action=getAdminUserUpdateForm&loginID=" . $userArray['loginID'] . "&height=230&width=315&modal=true\",400,350)' class='thickbox'><img src='images/edit.gif' alt='"._("edit password or admin status")."' title='"._("edit password or admin status")."'></a></td>";
echo "<td><a href='javascript:void(0);' class='deleteUser' id='" . $userArray['loginID'] . "'><img src='images/cross.gif' alt='"._("remove")."' title='"._("remove")."'></a></td>";
echo "</tr>";
}

?>
</table>
<a href='ajax_forms.php?action=getAdminUserUpdateForm&loginID=&height=215&width=315&modal=true' class='thickbox' id='addUser'><?php echo _("add new user")?></a>
<a href='javascript:void(0)' onclick='javascript:myDialog("ajax_forms.php?action=getAdminUserUpdateForm&loginID=&height=215&width=315&modal=true",400,350)' class='thickbox' id='addUser'><?php echo _("add new user")?></a>
<?php

}else{
echo "(none found)<br /><a href='ajax_forms.php?action=getUserUpdateForm&loginID=&height=275&width=315&modal=true' class='thickbox' id='addUser'>"._("add new user")."</a>";
echo "(none found)<br /><a href='javascript:void(0)' onclick='javascript:myDialog(\"ajax_forms.php?action=getUserUpdateForm&loginID=&height=275&width=315&modal=true\",300,350)' class='thickbox' id='addUser'>"._("add new user")."</a>";
}

break;
Expand Down
2 changes: 1 addition & 1 deletion auth/ajax_processing.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
$sUser->passwordPrefix = $prefix;
}

if ($_POST['adminInd'] == "1"){
if ($_POST['adminInd'] == "1" || $_POST['adminInd'] == "Y"){
$sUser->adminInd = "Y";
}else{
$sUser->adminInd = "N";
Expand Down
6 changes: 5 additions & 1 deletion auth/css/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ table.surroundBox {
border-color: #e6e5e9;
border-collapse: collapse;
border-spacing: 0;
font-size:100%;
font-size:90%;
width: 100% !important;
}

Expand Down Expand Up @@ -442,3 +442,7 @@ p.fontText {
border: solid 1px #306d9c;
padding: 20px;
}

.no-titlebar .ui-dialog-titlebar {
display: none;
}
5 changes: 3 additions & 2 deletions auth/index.php
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,9 @@
<link rel="SHORTCUT ICON" href="images/favicon.ico" />
<link rel="stylesheet" href="//maxcdn.bootstrapcdn.com/font-awesome/4.3.0/css/font-awesome.min.css">
<link href='https://fonts.googleapis.com/css?family=Open+Sans:100,400,300,600,700' rel='stylesheet' type='text/css'>
<script type="text/javascript" src="../js/plugins/jquery-1.8.0.js"></script>
<script type="text/javascript" src="js/plugins/thickbox.js"></script>
<script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jquery/3.6.0/jquery.min.js"></script>
<link rel="stylesheet" href="https://ajax.googleapis.com/ajax/libs/jqueryui/1.12.1/themes/smoothness/jquery-ui.css"></script>
<script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jqueryui/1.12.1/jquery-ui.min.js"></script>
<script type="text/javascript" src="js/common.js"></script>
<script type="text/javascript" src="../js/plugins/Gettext.js"></script>
<?php
Expand Down
2 changes: 1 addition & 1 deletion auth/install/auth.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function register_auth_provider()
"default_value" => "coral_auth"
],
"config_file" => [
"path" => $protected_module_data{"config_file_path"},
"path" => $protected_module_data["config_file_path"],
]
],
"function" => function($shared_module_info) use ($MODULE_VARS, $protected_module_data, $version) {
Expand Down
3 changes: 1 addition & 2 deletions auth/js/admin.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ function updateUsers() {
data: "action=getUsers",
success: function(html) {
$("#div_users").html(html);
tb_reinit();
bind_removes();
}

Expand All @@ -51,7 +50,7 @@ function submitUserForm(){
// ajax call to add/update
$.post("ajax_processing.php?action=submitUser", { loginID: $("#textLoginID").val(), editLoginID: $("#editLoginID").val(), password: $("#password").val(), adminInd: getCheckboxValue('adminInd') } ,
function(data){
tb_remove();
myCloseDialog();
updateUsers();
return false;
}
Expand Down
30 changes: 29 additions & 1 deletion auth/js/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ if (!Array.prototype.indexOf)
}

function getCheckboxValue(field){
if ($('#' + field + ':checked').attr('checked')) {
if ($('#' + field)[0].checked) {
return 1;
}else{
return 0;
Expand Down Expand Up @@ -155,3 +155,31 @@ function postwith (to,p) {
myForm.submit() ;
document.body.removeChild(myForm) ;
}


function myDialog(loadForm, h,w){
if (h < 800) h = 'auto';
if (w < 800) w = w * 1.2;

$('<div/>').dialog({
modal: true,
open: function ()
{
if ($(this).is(':empty')) {
$(this).load(loadForm);
}
},
height: h,
width: w,
// title:"JQuery Dialog"
dialogClass: "no-titlebar"
});
}

function myCloseDialog(){
//$(this).dialog('close')
//$(this).closest('.ui-dialog-content').dialog('close');
// $(formName).dialog( "close" )
$('.ui-dialog-content').dialog('destroy');
}

Loading