Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Resources Module #777

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Fix for Resources Module #777

merged 3 commits into from
Oct 4, 2024

Conversation

rtatterson
Copy link
Member

Fixes two issues in the Resources Module:

  • The resource accounts modal had a typo stopping it from saving data properly

  • The costs table needs additional numeric normalization for both initial display and during the saving process, as was done for the taxRate field in the 2024.04 release

stephanieleary and others added 3 commits September 13, 2024 11:04
@stephanieleary @spaceisntsyntax
Address additional numeric fields
3f4d6d5 
Allow zeroes in resource cost fields: as with the taxRate field, other
numeric fields need to default to zero (0) rather than an empty string.

Format zero as currency in cost tables: Empty values in the cost table
are meant to be interpreted as a zero (0), formatted in the appropriate
locale, rather than an empty string.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
@stephanieleary @spaceisntsyntax
Fix modal close issue in Resources > Accounts
323dc2b 
Corrects the function used to close the dialog for adding or editing
resource accounts. Also adjusts the permissions of the sidebar
navigation so that site admins are allowed to access the Accounts
screen.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
@andyp-uk
Merge pull request #776 from EquinoxOpenLibraryInitiative/post-2024.0…
8a25c86 
…4-resource-fixes

Post-2024.04 resource fixes
@rtatterson rtatterson requested review from andyp-uk and mcreece and removed request for andyp-uk October 3, 2024 17:45
@andyp-uk andyp-uk merged commit dd24afe into master Oct 4, 2024
@andyp-uk
Copy link
Contributor

andyp-uk commented Oct 4, 2024

Merged this as changes were already tested under PR #776.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcreece mcreece mcreece approved these changes

@andyp-uk andyp-uk Awaiting requested review from andyp-uk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rtatterson @andyp-uk @mcreece @stephanieleary