lang: improve AccountNotProgramOwned error msg or add new error

[paul-schaaf]

Current error msg is:

The given account is not owned by the executing program

But Account can also wrap types that are owned by a different program (same for AccountLoader)

how about

The given account is owned by a different program than expected

[losman0s]

Do we want to change the wording of the error enum as well (could break some projects), from AccountNotProgramOwned to AccountOwnedByWrongProgram for instance, or is the current one accurate enough?

[paul-schaaf]

@losman0s AccountOwnedByWrongProgram sgtm

[losman0s]

@paul-schaaf For my sanity, do you have a concrete example/scenario where the current error would be thrown and be misleading?

[paul-schaaf]

@losman0s when you have an Account<'info, Data> in your derive Accounts struct and Data comes from a different anchor program Zand the account passed in does not have the id of that program, you currently get the error The given account is not owned by the executing program even though the account you expect is not owned by the executing program but by program Z

[losman0s]

@paul-schaaf Ok, so the macro behaves correctly, and just reports confusingly. i.e: when we specify through the Data account's validation macro that we expect it to be owned by z, but that it is found to belong to y, it does throw, but reports the confusing message.

[paul-schaaf]

@losman0s correct