Update error wording to reflect actual cause #1154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Error message thrown in case of wrong account ownership is too restrictive, and can mislead the developer.
Any
Account<'info, XXX>
in an endpoint'sderive(Accounts)
struct is automatically validated at runtime to be owned by the program (~crate) it was created in (c.f. here for the check, and here to see how the#[account]
macro automatically sets an account struct's owner). However, when a client call provides an account owned by an unexpected program, the validation fails (good) with the confusing error messageThe given account is not owned by the executing program
(bad).This does not reflect that fact that an account can very well be owned by any program other than the one executing.
Summary of Changes
Move to suggested error enum name and error message:
Fixes #1100