Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript migrations #124

Closed
armaniferrante opened this issue Mar 25, 2021 · 3 comments
Closed

Typescript migrations #124

armaniferrante opened this issue Mar 25, 2021 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@armaniferrante
Copy link
Member

Currently the migrations feature is javascript only.

@armaniferrante armaniferrante added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 25, 2021
@armaniferrante
Copy link
Member Author

armaniferrante commented Mar 25, 2021

Might be able to use something like https://github.com/TypeStrong/ts-node, or we can just run tsc + node seprately (I prefer the latter I think, so that we can avoid an additional dependency).

@armaniferrante
Copy link
Member Author

armaniferrante commented Mar 25, 2021

We can just do what we do for typescript tests. I.e. check for a tsconfig and a .ts extension on the deploy script, and if they exist, run the typescript flow here https://github.com/project-serum/anchor/blob/master/cli/src/main.rs#L1380.

@armaniferrante
Copy link
Member Author

Addressed by #132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant