Feat/migrations typescript support #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build is failing due to solana-labs/solana#16207. It also fails on master, so it's not caused by these changes. |
Closed
armaniferrante
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below code adds support for Ts migration files.
Things to know:
• The script will transpile the
deploy.tsfile usingtscto the migrations dir. The resultingdeploy.jswill be deleted upon successful script completion.• There are some conflicts when using
import * as anchor from "..."with a 3rd party lib. Hence the script sticking with commonjs require. Intellisense raises a missing @types/node.• I added a different template in ts_deploy_script with an example ts async function although it was not absolutely necessary. I thought this template was bound to evolve in the future and that it provided clearer intent to readers.