ts: fix methods builder .accounts requiring global programs
#1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callensm
changed the title
.accounts requiring global programs.accounts requiring global programs
callensm
changed the title
.accounts requiring global programs.accounts requiring global programs
NBNARADHYA
pushed a commit
to MLH-Fellowship/anchor
that referenced
this pull request
Mar 8, 2022
NBNARADHYA
pushed a commit
to MLH-Fellowship/anchor
that referenced
this pull request
Mar 9, 2022
NBNARADHYA
pushed a commit
to MLH-Fellowship/anchor
that referenced
this pull request
Mar 9, 2022
NBNARADHYA
pushed a commit
to MLH-Fellowship/anchor
that referenced
this pull request
Mar 9, 2022
NBNARADHYA
pushed a commit
to MLH-Fellowship/anchor
that referenced
this pull request
Mar 9, 2022
NBNARADHYA
pushed a commit
to MLH-Fellowship/anchor
that referenced
this pull request
Mar 9, 2022
This was referenced Mar 21, 2022
This was referenced Mar 29, 2022
This was referenced Apr 5, 2022
This was referenced Apr 14, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After my last PR (#1539), the
.accounts()function on the methods builder was requiring that global on-chain programs (systemProgram,tokenProgram, etc) be manually added.This PR fixes that by having a static mapping in
AccountsResolverof the resolvable global names and theirPublicKeys and then excluding those names from the object provided to.accounts().This has the implication that we no longer allow developers to manually add those program public keys to the
.accounts()object which would prevent user error with public key inputs.resolves #1547