Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amv improvements #1670

Merged

Conversation

italoacasas
Copy link
Contributor

@italoacasas italoacasas commented Mar 22, 2022

Changelog

  • avm install 0.0.0 ignores request if 0.0.0 is already installed
  • avm install 0.0.0 switches to version 0.0.0 after successfully installation
  • avm update install latest stable version

Issues

#1663

@italoacasas italoacasas changed the title amv install improvements amv improvements Mar 22, 2022
@italoacasas italoacasas changed the title amv improvements amv improvements Mar 22, 2022
@italoacasas italoacasas force-pushed the feature/avm-install-improvements branch from 37818e4 to 3f10ccf Compare March 22, 2022 20:46
avm/src/lib.rs Outdated Show resolved Hide resolved
@paul-schaaf
Copy link
Contributor

pls update the CHANGELOG.md too

I think this is even a breaking change. because of this:

avm install 0.0.0 switches to version 0.0.0 after successfully installation

@italoacasas
Copy link
Contributor Author

pls update the CHANGELOG.md too

I think this is even a breaking change. because of this:

avm install 0.0.0 switches to version 0.0.0 after successfully installation

Yes, I agree with you.

@italoacasas italoacasas force-pushed the feature/avm-install-improvements branch from 2c53933 to af0eca3 Compare March 23, 2022 02:21
@italoacasas italoacasas force-pushed the feature/avm-install-improvements branch from af0eca3 to fac4e78 Compare March 23, 2022 02:22
@@ -563,4 +574,4 @@ Initial release.
* spl: `anchor-spl` crate providing CPI clients for Anchor programs.
* client: `anchor-client` crate providing Rust clients for Anchor programs.
* ts: `@project-serum/anchor` package for generating TypeScript clients.
* cli: Command line interface for managing Anchor programs.
* cli: Command line interface for managing Anchor programs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened here? I saw that in a different PR too 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably just a github bug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual Studio Code doing weird stuff when I saved the document 😵‍💫

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh maybe a different os line break?

Copy link
Contributor Author

@italoacasas italoacasas Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, not sure honestly, but I think it is more than just that. For example, if I use VSCode, when I save, all the * get replaced by -.

@paul-schaaf paul-schaaf merged commit e999511 into coral-xyz:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants