Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add discriminator length checks #1678

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Add discriminator length checks #1678

merged 2 commits into from
Mar 24, 2022

Conversation

smoelius
Copy link
Contributor

This PR adds discriminator length checks in a few places where they appear to be missing.

@paul-schaaf
Copy link
Contributor

this is not a vulnerability because the array_ref will fail if the data is shorter than the discriminator but an error msg is still better than a panic!

@smoelius
Copy link
Contributor Author

@paul-schaaf I agree with what you said.

@paul-schaaf paul-schaaf merged commit 0f7675c into coral-xyz:master Mar 24, 2022
@paul-schaaf
Copy link
Contributor

Thanks for the contribution!

@smoelius smoelius deleted the discriminator-length-checks branch March 24, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smoelius @paul-schaaf