-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ts: make Provider
an interface and update provider functions
#1707
ts: make Provider
an interface and update provider functions
#1707
Conversation
Provider
an interface and update provider functions
…ovider interface -> remove confirm
Turning this into a draft so we dont accidentally merge it. It is ready for review though |
ts/src/provider.ts
Outdated
|
||
if (transaction.nonceInfo && signers) { | ||
if (wallet) { | ||
transaction = await wallet.signTransaction(transaction); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the wallet parameter and force the caller to sign prior to passing in the tx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember why I did it this way now. simulateTransaction
has all this logic to efficiently get the blockhash and that has to be done before the first signature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make the simulate changes and merge this!
Submodule PRs: