ts: Fix IDL type issues #1726
Closed
ts: Fix IDL type issues #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an empty prettier config file to inform editors to use it instead of any user defaults. The empty config causes prettier to use the defaults which are what are already in use.
Juici
changed the title
|
Hi Anchor team, |
Juici
changed the title
|
Hey! Also blocked by this. Are there any issues with merging? |
|
Hey, any update? This PR fixes a serious problem because, right now, all nested structures are generated as |
|
Any feedback from the anchor team on what is blocking this would be greatly appreciated. Currently I have to rely on using the npm package patch-package to patch the |
|
Superceded by: #2482 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
never.Bufferfor thebytestype.Notes
Currently the changes made would result in enum variant names being as described in the IDL, that means that no case conversion would be done, this would be a breaking change. This could be mitigated by either storing the camelcased enum variant names in the IDL, or by doing the camelcase conversion at a type level.
In terms of camelcase at a type level, I have created a demo here: https://github.com/Juici/camelcase-ts.