Add send w/ spinner and options to rust client #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client/src/lib.rs
Outdated
| @@ -556,6 +553,29 @@ impl<'a> RequestBuilder<'a> { | |||
| .send_and_confirm_transaction(&tx) | |||
| .map_err(Into::into) | |||
| } | |||
|
|
|||
| pub fn send_with_spinner_and_config(self, config: RpcSendTransactionConfig) -> Result<Signature, ClientError> { | |||
There was a problem hiding this comment.
Please add a changelog entry.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is very clunky to take a builder and convert that to a send w/ options. Sending with options is useful in order to be able to customize the transaction config in order to turn off preflight checks (which make it easier to debug errors).
This change adds a single function to the RequestBuilder struct, send_with_spinner_and_config (name is placeholder at the moment. Feel free to change it if its too long). Tests passing and tested it locally and everything still works.