Fix: IDL gen byte string lit parsing #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stegaBOB is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
|
The rent exempt test is failing in master too I believe. Current SPL token is using features that weren't available to the 1.8 rbpf tools. |
yf-castel
pushed a commit
to castle-finance/anchor
that referenced
this pull request
Aug 15, 2022
yf-castel
pushed a commit
to castle-finance/anchor
that referenced
this pull request
Aug 15, 2022
Henry-E
pushed a commit
to Henry-E/anchor
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Byte strings were not being parsed properly due to the
matchstatement not catching synLits. This PR adds a pattern to catch and parse these.Current build behavior with
seeds=true:WARNING: unexpected seed: Lit(ExprLit { attrs: [], lit: ByteStr(LitByteStr { token: b"some string" }) })This will turn the entire seed into
Noneif a seeds group contains a byte string literal. In other words, the entire PDA object will be missing in the IDL.With the fix, the warning is gone and IDLs are generated as they should be.