Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts: Narrow AccountClient to it's appropriate type #2440

Merged

Conversation

quellen-sol
Copy link
Contributor

Problem

As described in #1706, T in AccountClient currently shows as a union of all the account types.

Changes

Use the IdlAccounts type to determine T based on a new generic N (name of the account)

@vercel
Copy link

vercel bot commented Mar 21, 2023

@quellen-sol is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@quellen-sol quellen-sol changed the title Narrow AccountClient to it's appropriate type ts: Narrow AccountClient to it's appropriate type Mar 22, 2023
@armaniferrante armaniferrante merged commit f307729 into coral-xyz:master Mar 24, 2023
@quellen-sol quellen-sol deleted the fix-account-union-typing branch March 24, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants