Support --upgradeable-program in anchor test #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickguo is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
nickguo
force-pushed
the
anchor_test_upgradeable_program_flag
branch
from
8b56ed1
to
4fceec7
Compare
nickguo
force-pushed
the
anchor_test_upgradeable_program_flag
branch
3 times, most recently
from
265ae11
to
2d00b48
Compare
nickguo
force-pushed
the
anchor_test_upgradeable_program_flag
branch
from
2d00b48
to
65032e2
Compare
There was a problem hiding this comment.
LGTM other than a couple of small issues I've mentioned.
Could you add an entry to the CHANGELOG before we merge?
nickguo
force-pushed
the
anchor_test_upgradeable_program_flag
branch
2 times, most recently
from
2ff4e67
to
e42da26
Compare
acheroncrypto
requested changes
Oct 2, 2023
There was a problem hiding this comment.
There is a conflict in the CHANGELOG file that blocks the merge. Could you rebase to master?
nickguo
force-pushed
the
anchor_test_upgradeable_program_flag
branch
from
e42da26
to
c2c8ecd
Compare
nickguo
force-pushed
the
anchor_test_upgradeable_program_flag
branch
from
c2c8ecd
to
f076e7d
Compare
acheroncrypto
approved these changes
Oct 3, 2023
|
Thank you for the contribution and addressing the feedback quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please advise on how to best test this change