-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path to PDA seeds parse #2699
Add path to PDA seeds parse #2699
Conversation
@johnanthos is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also couldn't find tests for these use cases but maybe that should be a separate task.
Yes, it would be great to have tests for this in this PR. We have IDL related tests here if you'd like to add.
@acheroncrypto a simple test added with a custom bash script to catch the warning from the described issue because it does not throw an error but just a warning message. Let me know if this makes sense or if the goal should be to change on the implementation side. |
This looks great. Would you mind adding this fix to the CHANGELOG? |
Done @acheroncrypto |
c1028a0
to
ede4395
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Problem
When seeds are declared as constants, a warning is thrown when building.
The issue is thoroughly described at #2697
Summary of changes
Path
as an option to seeds parsingNotes
Likely more use cases besides parsing as string literal need to be covered under this
Path
scenario but I'd appreciate anyone else's input on that as I'm still not entirely familiar on all the possible use cases.Also couldn't find tests for these use cases but maybe that should be a separate task.
Fixes
Fixes #2697