cli: Require explicit overflow-checks
flag
#2716
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
overflow-checks
flag is implicitly disabled by default.Anchor workspaces that are crated with
anchor init
have this flag enabled by default but Anchor doesn't do any checks for it after workspace creation.Summary of changes
overflow-checks
flag in workspaceCargo.toml
overflow-checks = true
in all CI testsanchor build
fails whenoverflow-checks
is not specifiedPros & Cons
Enabling
overflow-checks
not only allows to use regular math operations in a safe manner(and avoidchecked_*().unwrap()
) but it also works with dependencies i.e. a program will panic if a math operation in one of its dependencies overflows.The only downside I can think of is that unchecked math operations cost a bit more compute units but this should be negligible.
Closes #1759