-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Add priority fees to idl commands #2845
cli: Add priority fees to idl commands #2845
Conversation
andreihrs
commented
Mar 15, 2024
•
edited
Loading
edited
- add optional priority fee argument
- get max between recommended priority fee from the client and priority fee passed, so that txs have a higher chance to go through
- add retry on write buffer, so the operation doesn't fail on blockhash expired/transaction expired midway
- make the buffer size small on writing, so it doesn't fail on tx size too big when adding the compute budget unit fee instruction
@andreihrs is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely need priority fees and retry logic, so thank you for working on this!
1625582
to
6409b85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one small issue, other than that, this looks great!
Before we merge, could you note this change in the CHANGELOG?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
It would be helpful to add some examples to the docs or even just here about what the usage looks like |
Yeah, we can do that (after the next release because the doc website updates live), I'll also note this in the release notes. The usage is pretty simple e.g. Most of the time, you wouldn't even need to specify this argument since we use the median priority fee by default. Also the fees are broken i.e. increasing the priority fee after a certain point doesn't make your transaction more likely to land. |