Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "align" repr support in declare_program! #3056

Merged
merged 10 commits into from
Jul 1, 2024

Conversation

0xBurbo
Copy link
Contributor

@0xBurbo 0xBurbo commented Jun 26, 2024

Problem: During declare_program Current code generates token stream that writes account representation alignment including the integer suffix: "#[align(8usize)]". This breaks compilation, and should look like "#[align(8)]"

This commit uses a proc_macro2 literal without the integer suffix to resolve the issue.

Copy link

vercel bot commented Jun 26, 2024

@0xBurbo is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto added lang fix Bug fix PR labels Jun 27, 2024
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Could you note this fix in the CHANGELOG?

lang/attribute/program/src/declare_program/common.rs Outdated Show resolved Hide resolved
@0xBurbo
Copy link
Contributor Author

0xBurbo commented Jul 1, 2024

Changelog has been updated

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@acheroncrypto acheroncrypto merged commit e68b96f into coral-xyz:master Jul 1, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PR lang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants