Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass cargo args to idl generation #3059

Conversation

biryukovmaxim
Copy link
Contributor

closes #3054

Copy link

vercel bot commented Jun 27, 2024

@biryukovmaxim is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto added idl related to the IDL, either program or client side feature labels Jun 27, 2024
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks great other than the breaking change (new parameter).

idl/src/build.rs Show resolved Hide resolved
idl/src/build.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One last thing before we merge, could you note this feature in the CHANGELOG?

@biryukovmaxim
Copy link
Contributor Author

Thanks! One last thing before we merge, could you note this feature in the CHANGELOG?

done

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@acheroncrypto acheroncrypto merged commit ca7fcee into coral-xyz:master Jun 28, 2024
32 of 49 checks passed
@biryukovmaxim biryukovmaxim deleted the pass-cargo-args-while-idl-build branch August 12, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature idl related to the IDL, either program or client side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation Error with Passing Cargo args when build program when IDL Generation is enabled in Anchor 0.30
2 participants