syn: Remove bpf
target support in hash
feature
#3078
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
anchor-syn
is used for code parsing and generation, but we also havehash
feature that hasbpf
target related code:anchor/lang/syn/src/hash.rs
Lines 101 to 116 in 0a1d458
This whole module was copied from
solana_program::hash
, which is likely whybpf
related code wasn't removed. On-chain hashing should be done usingsolana_program::hash
, which has the exact same functionality.Also,
bpf
target arch has been deprecated as mentioned in #3062 (comment).Summary of changes
Remove
bpf
target arch related code.