lang: Add a sanity check for unimplemented token extensions #3090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Codegen currently skips unimplemented token extensions:
anchor/lang/syn/src/codegen/accounts/constraints.rs
Line 940 in 79d1cec
This is not ideal since extensions are defined internally by us (from the user's constraints). If a token extension constraint is specified, and we've included the extension in the internal
extensions
variable, then not doing anything with it later on should be considered an internal bug. Therefore, it's better to panic in this case rather than doing nothing.Summary of changes
Panic via
unimplemented!
macro if an extension has a missing implementation.