Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang: Add a sanity check for unimplemented token extensions #3090

Conversation

acheroncrypto
Copy link
Collaborator

Problem

Codegen currently skips unimplemented token extensions:

This is not ideal since extensions are defined internally by us (from the user's constraints). If a token extension constraint is specified, and we've included the extension in the internal extensions variable, then not doing anything with it later on should be considered an internal bug. Therefore, it's better to panic in this case rather than doing nothing.

Summary of changes

Panic via unimplemented! macro if an extension has a missing implementation.

Copy link

vercel bot commented Jul 17, 2024

@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto added lang fix Bug fix PR labels Jul 17, 2024
@acheroncrypto acheroncrypto merged commit 0dd6b4e into coral-xyz:master Jul 17, 2024
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PR lang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant