lang: Parse #[account]
attribute arguments with syn
#3140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#[account]
macro arguments are parsed by converting the tokens to string and interpreting:anchor/lang/attribute/account/src/lib.rs
Lines 70 to 94 in f6a8042
This makes adding named arguments e.g.
discriminator = <EXPR>
challenging.Furthermore, any argument other than
zero_copy
andzero_copy(unsafe)
is interpreted as custom namespace, even when the argument is not a string.Summary of changes
syn
#[account(my_namespace)]
) are no longer interpreted as custom namespaces, and they return an error insteadNote: This PR is part of a greater effort explained in #3097.