Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade time to 0.3.36 #3143

Merged

Conversation

acheroncrypto
Copy link
Collaborator

Problem

Building the CLI with latest stable rust (rustc 1.80.0) results in a compile error:

   Compiling time v0.3.29
error[E0282]: type annotations needed for `Box<_>`
  --> /home/x/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.29/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

For more information about this error, try `rustc --explain E0282`.
error: could not compile `time` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Upstream issue: time-rs/time#693

Summary of changes

Update time crate to 0.3.36.

Note

avm install will forever be broken for all old versions when using rustc >=1.80 because it uses --locked argument internally, and because Rust lang won't fix it as mentioned in rust-lang/rust#127343 (comment).

The solution to this problem for old versions can be found in #3126 (comment). Additionally, we release pre-built binaries to NPM for x86_64-linux at @coral-xyz/anchor-cli.

Copy link

vercel bot commented Aug 2, 2024

@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto added the dependencies Pull requests that update a dependency file label Aug 2, 2024
@acheroncrypto acheroncrypto merged commit 56af130 into coral-xyz:master Aug 2, 2024
0 of 9 checks passed
@cleantechie
Copy link

Thanks @acheroncrypto for the fix

@maxims94
Copy link

To install an older Anchor version with avm install, temporarily change your system's Rust toolchain to <1.80. In my case, rustup run 1.78.0-x86_64-unknown-linux-gnu avm install 0.30.1 worked. (Use rust toolchain list to see which ones are installed)

@Xeonacid
Copy link

Could the team make a new release to get this fixed? Thanks!

@imprfekt
Copy link

imprfekt commented Nov 7, 2024

wen new release @acheroncrypto?

@acheroncrypto
Copy link
Collaborator Author

Next version has been ready for ~2 months (#3259), but we're waiting for an audit.

This specific issue has been fixed in #3315 though (without requiring a new release). You might need to upgrade avm to latest if you've installed it before that commit:

cargo install --git https://github.com/coral-xyz/anchor avm --locked --force

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants