Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cli completions + clap version bump to v4.5.17 #3251

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

zilayo
Copy link
Contributor

@zilayo zilayo commented Sep 15, 2024

Small QoL improvement by introducing CLI completions for Anchor.

Instead of repeatedly using anchor --help, we can now use anchor + tab to generate completions.

This adds the clap_completions dependency to Anchor.
clap_completions uses clap v4.5.17, so the clap version used in Anchor has also been bumped.

There are no breaking changes between the currently used v4.2.4 and v4.5.17 - mainly just performance + bug fixes (https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)

image image

Update:

Also added completions for avm.

image

Copy link

vercel bot commented Sep 15, 2024

@zilayo is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto added cli avm feature documentation Improvements or additions to documentation labels Sep 15, 2024
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very helpful, thanks for adding it and extra thanks for adding the documentation too.

Just some nits and we can get this in.

cli/src/lib.rs Outdated Show resolved Hide resolved
avm/src/main.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@zilayo
Copy link
Contributor Author

zilayo commented Sep 15, 2024

This is very helpful, thanks for adding it and extra thanks for adding the documentation too.

Just some nits and we can get this in.

all nits fixed!

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@acheroncrypto acheroncrypto merged commit 4866680 into coral-xyz:master Sep 16, 2024
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
avm cli documentation Improvements or additions to documentation feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants