Fix: Event listener not firing when creating associated accounts

[Standaa]

The code makes the assumption that a program log will always chronologically "follow" it's governing program.
Nonetheless, when the same transaction also initializes an associated account, this order gets mixed up.
The last program to be used becomes a cpi.

Let's take an example:

Logs for a simple transaction might look like:

[
  'Program 3F3r9Njk8YkVJVyaxW66LySAxpG9FmNX6QAQ5Jc8xUWi invoke [1]', <==== LAST REGISTERED PROGRAM IN STACK
  'Program log: YLjF84sCWpQFAAAAAAAAAAUAAABoZWxsbw==',    <==== BELONGS TO PREVIOUS PROGRAM
  'Program 3F3r9Njk8YkVJVyaxW66LySAxpG9FmNX6QAQ5Jc8xUWi consumed 4636 of 200000 compute units',
  'Program 3F3r9Njk8YkVJVyaxW66LySAxpG9FmNX6QAQ5Jc8xUWi success'
]

Whereas Logs for the same transaction initializing an associated account will be:

[
  'Program 8DKf8QXhaptkAxVUEvRYLrwNzfPjAm3GveYrfernAidC invoke [1]',
  'Program 11111111111111111111111111111111 invoke [2]',
  'Program 11111111111111111111111111111111 success',  <==== LAST REGISTERED PROGRAM IN STACK
  'Program log: YLjF84sCWpQFAAAAAAAAAAUAAABoZWxsbw==',   <==== BELONGS TO 8DKf8QX... 
  'Program 8DKf8QXhaptkAxVUEvRYLrwNzfPjAm3GveYrfernAidC consumed 15929 of 200000 compute units',
  'Program 8DKf8QXhaptkAxVUEvRYLrwNzfPjAm3GveYrfernAidC success'
]

Because the code first checks whether execution.program() === this.programId.toString() before triggering an event. The call is never made as this condition can never be met.

The fix pops the last program in the stack if any program ends successfully.
A new assumption being made is that a success will always "belong" to the last program in the stack.

[armaniferrante]

Let's also add a test for this.

[Standaa]

Following your discord comment here:

It appears the problem is that the previous code makes the assumption that a consumed log will be emitted at the end of cpi.
With the system program, this appears not to be the case.

I removed the "consumed" check as the OR condition crashed the existing test.
Monitoring the "success" log should be enough, as It looks like a "success" log will always be emitted, no matter if the call is a CPI or a trad call. Or maybe there was a reason why you did not do it ?

[Standaa]

Was not sure how to test creation of the associated account. Tried to check in the client whether the account had been created like so:

const account = await program.account.testData.associated(
  program.provider.wallet.publicKey,
);

But it did not work. My guess is that program.simulate() has a limited lifetime ?
I am passing the pubkey back in an event and checking that it matches as a workaround, but it is not great.

[xjcaa]

This issue seems to occur when using associated accounts in general, thanks for this :D