Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flag to keep local validator running #662

Closed
wants to merge 1 commit into from
Closed

Added flag to keep local validator running #662

wants to merge 1 commit into from

Conversation

munanadi
Copy link
Contributor

@munanadi munanadi commented Sep 2, 2021

This is a PR for #647
Added a keep-validator flag to anchor test to leave the local validator running.

I tried finding something to issue SIGINT but no luck. So, I implemented this hacky one instead looking around the code.

Will this work? This is my first ever PR. Sorry for this ugly code.

/// Flag to leave the local validator running after tests
/// to be able to check the transactions.
#[clap(long)]
keep_validator: bool,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets rename this detach.

@armaniferrante
Copy link
Member

We need to rebase this on master for the tests to pass.

@munanadi
Copy link
Contributor Author

Opened a new PR #770 Sorry for the trouble.

@munanadi munanadi closed this Sep 20, 2021
@munanadi munanadi deleted the flag-to-keep-validator-running branch September 20, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants