Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for LoaderAccount #792

Merged
merged 23 commits into from
Oct 8, 2021
Merged

Support for LoaderAccount #792

merged 23 commits into from
Oct 8, 2021

Conversation

NorbertBodziony
Copy link
Contributor

Got stuck on generics_test.rs

Let me know if it even makes sense.

@armaniferrante
Copy link
Member

Addresses #643

@NorbertBodziony NorbertBodziony marked this pull request as ready for review October 6, 2021 13:04
armaniferrante
armaniferrante reviewed Oct 6, 2021
View reviewed changes
Copy link
Member

@armaniferrante armaniferrante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Last thing we need to do is add this to an integration test.

@NorbertBodziony
Copy link
Contributor Author

Gonna work on this tmw.

@NorbertBodziony
Copy link
Contributor Author

All should be done refactored zero_copy test + removed state and added CPI using zero_copy

armaniferrante
armaniferrante reviewed Oct 8, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@armaniferrante armaniferrante merged commit 1c5c6a8 into coral-xyz:master Oct 8, 2021
@armaniferrante armaniferrante mentioned this pull request Oct 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armaniferrante armaniferrante armaniferrante left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NorbertBodziony @armaniferrante