Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds sentry to backpack-api and app-mobile #3311

Merged
merged 7 commits into from
Mar 12, 2023
Merged

Conversation

peterpme
Copy link
Contributor

@peterpme peterpme commented Mar 12, 2023

adds sentry perf / error monitoring

i need help with:

  • adding environment variables (SENTRY_DSN)
  • knowing which fields to filter out
  • knowing which services to add as projects

@vercel
Copy link

vercel bot commented Mar 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
backpack ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 12, 2023 at 10:25PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2023

yarn.lock changes

Summary

Status Count
ADDED 59
UPDATED 1
DOWNGRADED 2
REMOVED 2
Click to toggle table visibility
Name Status Previous Current
@colors/colors ADDED - 1.5.0
@contrast/fn-inspect ADDED - 3.3.0
@grpc/grpc-js ADDED - 1.8.12
@grpc/proto-loader ADDED - 0.7.5
@newrelic/aws-sdk ADDED - 5.0.2
@newrelic/koa ADDED - 7.1.1
@newrelic/native-metrics ADDED - 9.0.0
@newrelic/superagent ADDED - 6.0.0
@protobufjs/aspromise ADDED - 1.1.2
@protobufjs/base64 ADDED - 1.1.2
@protobufjs/codegen ADDED - 2.0.4
@protobufjs/eventemitter ADDED - 1.1.0
@protobufjs/fetch ADDED - 1.1.0
@protobufjs/float ADDED - 1.0.2
@protobufjs/inquire ADDED - 1.1.0
@protobufjs/path ADDED - 1.1.2
@protobufjs/pool ADDED - 1.1.0
@protobufjs/utf8 ADDED - 1.1.0
@sentry/browser ADDED - 7.29.0
@sentry/cli ADDED - 1.74.4
@sentry/core ADDED - 7.42.0
@sentry/hub ADDED - 7.29.0
@sentry/integrations ADDED - 7.29.0
@sentry/node ADDED - 7.42.0
@sentry/react-native ADDED - 4.13.0
@sentry/react ADDED - 7.29.0
@sentry/replay ADDED - 7.29.0
@sentry/tracing ADDED - 7.42.0
@sentry/types ADDED - 7.42.0
@sentry/utils ADDED - 7.42.0
@sentry/wizard ADDED - 1.4.0
@solana/web3.js DOWNGRADED 1.73.3 1.63.1
@types/long ADDED - 4.0.2
@types/node UPDATED 18.14.1 18.15.0
@types/triple-beam ADDED - 1.3.2
@tyriar/fibonacci-heap ADDED - 2.0.9
agentkeepalive REMOVED 4.3.0 -
aproba ADDED - 1.2.0
are-we-there-yet ADDED - 1.1.7
code-point-at ADDED - 1.1.0
concat-stream ADDED - 2.0.0
console-control-strings ADDED - 1.1.0
fecha ADDED - 4.2.3
gauge ADDED - 2.7.4
has-unicode ADDED - 2.0.1
humanize-ms REMOVED 1.2.1 -
localforage ADDED - 1.10.0
logform ADDED - 2.5.1
long ADDED - 5.2.1
lru_map ADDED - 0.3.3
newrelic ADDED - 9.11.0
npmlog ADDED - 4.1.2
number-is-nan ADDED - 1.0.1
opn ADDED - 5.5.0
protobufjs ADDED - 7.2.2
r2 ADDED - 2.0.1
react-refresh DOWNGRADED 0.14.0 0.11.0
read-env ADDED - 1.3.0
safe-stable-stringify ADDED - 2.4.2
sentry-expo ADDED - 6.1.0
triple-beam ADDED - 1.3.0
typedarray ADDED - 0.0.6
wide-align ADDED - 1.1.5
winston-transport ADDED - 4.5.0

@github-actions github-actions bot added the backend Related to backend infra, reef or cf workers label Mar 12, 2023
@github-actions github-actions bot added the mobile Related to expo mobile app label Mar 12, 2023
@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
@sentry/cli@1.74.4 (added) install package.json via @sentry/react-native@4.13.0, sentry-expo@6.1.0, packages/app-mobile/package.json via @sentry/react-native@4.13.0, sentry-expo@6.1.0
Pull request report summary
Issue Status
Install scripts ⚠️ 1 issue
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore @sentry/cli@1.74.4

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@peterpme peterpme changed the title adds sentry adds sentry to backpack-api and app-mobile Mar 12, 2023
@@ -18,6 +18,7 @@ import { BottomSheetModalProvider } from "@gorhom/bottom-sheet";
import { SafeAreaProvider } from "react-native-safe-area-context";
import { WebView } from "react-native-webview";
import { RecoilRoot } from "recoil";
import * as Sentry from "sentry-expo";
Copy link
Contributor

@hkirat hkirat Mar 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we avoid this until we audit sentry-expo? Like adding it to the app-extension/app-mobile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sentry is already hooked up!

@peterpme peterpme merged commit 20478aa into master Mar 12, 2023
@peterpme peterpme deleted the peter/install-monitoring branch March 12, 2023 23:03
armaniferrante added a commit that referenced this pull request Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend infra, reef or cf workers mobile Related to expo mobile app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants