Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid copy in count / logical nulls #221

Merged

Conversation

alamb
Copy link

@alamb alamb commented Dec 14, 2023

This is a proposed improvement of apache#8511 to avoid copying Null Buffers in the count aggregator.

Note this targets apache#8511

I will also file a proposal to upstream this change into arrow-rs

cc @joroKr21 and @Dandandan

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@joroKr21
Copy link

Ok I see - it kinda makes sense, you handle the known types in a pattern match.
It's unlikely new types will be added before we can upstream this change 👍

@joroKr21 joroKr21 merged commit cecc493 into coralogix:bugfix/count-null Dec 14, 2023
23 checks passed
@alamb
Copy link
Author

alamb commented Dec 14, 2023

I think this may be overkill -- apache#8511 (review)

Closing this PR and let's keep the code simple unless we find some profile or benchmark where it matters

@alamb
Copy link
Author

alamb commented Dec 14, 2023

Doh, just missed it !

@alamb alamb deleted the alamb/logical_nulls_no_copy branch December 14, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants