Make extra* parameters configurable as objects
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matej-g
requested review from
povilasv,
oded-dd and
nicolastakashi
as code owners
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
matej-g
force-pushed
the
make-extra-params-objects
branch
3 times, most recently
from
eb6d0da to
1635037
Compare
Signed-off-by: Matej Gera <matejgera@gmail.com>
matej-g
force-pushed
the
make-extra-params-objects
branch
from
1635037 to
0daeb77
Compare
povilasv
reviewed
Oct 5, 2023
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
povilasv
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is first part of work to address https://coralogix.atlassian.net/browse/ES-71.
Changing these parameters from array to objects will enable us to merge parameters provided by users and provided by default in our upstream chart.
The idea is instead of listing the objects in an array, we embed them in the parent object and each child object's key should correspond to the particular parameters name (e.g. environment variable name, volume name etc.).
Changes to
telemetry-shippercharts will follow up.