Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-2877]: clarify data-coral-url in docs for comment count #4330

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Aug 29, 2023

What does this PR do?

Update docs for comment counts to clarify when data-coral-url needs to be set.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

Where any tests migrated to React Testing Library?

How do we deploy this PR?

@kabeaty kabeaty requested review from tessalt and nick-funk August 29, 2023 17:33
@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for gallant-galileo-14878c ready!

Name Link
🔨 Latest commit 6550f98
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/64ee2be26efeb40008c829e3
😎 Deploy Preview https://deploy-preview-4330--gallant-galileo-14878c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Nice linking to the MDN docs for explanations of the URL types.

@tessalt tessalt merged commit 770f3f7 into develop Sep 26, 2023
@tessalt tessalt deleted the feat/CORL-2877-update-counts-docs-story-url branch September 26, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants