Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how .env file needs to reside under server/ #4343

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

nick-funk
Copy link
Contributor

@nick-funk nick-funk commented Sep 7, 2023

What does this PR do?

Document new .env file location in the docs for the mono-repo changes.

As doc says, the file needs to be placed at root of the server/ sub-directory.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

No new indices.

How do I test this PR?

  • read doc change
  • suggest rewording or different explanations if you think they are necessary

Where any tests migrated to React Testing Library?

No

How do we deploy this PR?

No special considerations.

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for gallant-galileo-14878c ready!

Name Link
🔨 Latest commit 6e0f91f
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/6571f45655b432000867a630
😎 Deploy Preview https://deploy-preview-4343--gallant-galileo-14878c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@kabeaty kabeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you please also update the mentions of the .env file in environment-variables.md and installation.md?

@kabeaty kabeaty added this pull request to the merge queue Dec 7, 2023
Merged via the queue into develop with commit 5014d04 Dec 7, 2023
6 checks passed
@kabeaty kabeaty deleted the fix/docs-env-file-server branch December 7, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants