Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-2864] Left align fallback comment embed #4351

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

marcushaddon
Copy link
Contributor

What does this PR do?

This PR adds a text alignt: left; style rule to comment embed code so it will look better when embeded in emails.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None.

Does this PR introduce any new environment variables or feature flags?

No.

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

  1. Click the 'Embed comment' button on a comment, paste it somehwere and see that there is an additiona inline style rule aligning text to the left.
  2. See HTML of before and after attached to Jira ticket to see how it should appear in emails.

Where any tests migrated to React Testing Library?

No.

How do we deploy this PR?

No special considerations should be required.

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit e9c4455
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/6504b0d25d4637000802e14b

@tessalt tessalt merged commit f5c8d46 into develop Sep 26, 2023
@tessalt tessalt deleted the feat/CORL-2864-left-align-comment-embed-fallback branch September 26, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants