[CORL-2927] Use tenant locale to translate Graphql errors if available #4385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, it was grabbing the locale from the context only which was always set to en-US by default instead of retrieving from the tenant which has the accurate locale. if the tenant is not available, we simply default back to the context locale to be safe.
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
kabeaty
approved these changes
Nov 7, 2023
marcushaddon
approved these changes
Nov 14, 2023
kabeaty
deleted the
fix/CORL-2927-translate-errors-if-tenant-locale-available
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use tenant locale to translate Graphql errors if available.
Previously, it was grabbing the locale from the context only which was always set to en-US by default instead of retrieving from the tenant which has the accurate locale.
If the tenant is not available, we simply default back to the context locale to be safe.
This fixes the issue where reposting the same comment twice was not translating the "Are you sure? Your comment looks similar to your previous one" error correctly.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
None
Does this PR introduce any new environment variables or feature flags?
No
If any indexes were added, were they added to
INDEXES.md?No new indices.
How do I test this PR?
errors.ftlyet, wildWhere any tests migrated to React Testing Library?
No
How do we deploy this PR?
No special considerations.