Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-2920]: Community table fallbacks alignment updates #4388

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Nov 7, 2023

What does this PR do?

These changes update the styles for the community table in the admin so that all user data is displayed with the desired alignment.

If a username isn't available, the fallback message in this case should still be left aligned. All other columns should have their data vertically aligned in the middle, including the email data and its fallback message, member since, role, and status data.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

Go to the Community tab in the admin. If a username isn't available, the fallback message in this case should be left aligned. All other columns should have their data vertically aligned in the middle, including the email data and its fallback message, member since, role, and status data. (You can either update data so no username/email is available, or just comment out parts of the code that show the username/email so that the fallback shows)

Where any tests migrated to React Testing Library?

How do we deploy this PR?

Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 9047c81
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/654a9d3a4657ca000858206a

Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✅

Copy link
Contributor

@marcushaddon marcushaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing the fallback message for username left aligned, but I also see the other columns being left aligned, rather than in the center, which is what I understood from the PR description as the requirement. Should they be in the middle?

@kabeaty
Copy link
Contributor Author

kabeaty commented Nov 15, 2023

I'm seeing the fallback message for username left aligned, but I also see the other columns being left aligned, rather than in the center, which is what I understood from the PR description as the requirement. Should they be in the middle?

The other columns should still be left aligned. The requirement is that all columns then also have their data vertically centered, in addition to their horizontal left alignment.

@marcushaddon
Copy link
Contributor

I'm seeing the fallback message for username left aligned, but I also see the other columns being left aligned, rather than in the center, which is what I understood from the PR description as the requirement. Should they be in the middle?

The other columns should still be left aligned. The requirement is that all columns then also have their data vertically centered, in addition to their horizontal left alignment.

Ah that makes sense.

@kabeaty kabeaty added this pull request to the merge queue Dec 6, 2023
Merged via the queue into develop with commit c8c935b Dec 6, 2023
5 checks passed
@kabeaty kabeaty deleted the fix/CORL-2920-community-table-fallbacks-alignment branch December 6, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants