Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade akismet-api and use new payload types for spam checks #4438

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

nick-funk
Copy link
Contributor

@nick-funk nick-funk commented Nov 28, 2023

Special thanks to @Sentynel for bringing this to our attention in their fork PR (#4123)! We used the suggestions from their PR to update our Akismet types and submission style for our spam filters!

What does this PR do?

  • Updates our akismet-api dependency
  • Uses new types for the payloads sent through the AkismetClient to check for spam

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

No new indices.

How do I test this PR?

  • Configure the spam tooling (Akismet) under Admin > Configure > Moderation > Spam detection filter
    • Make sure the filter is turned on (i.e. Spam detection filter option)
    • Be sure to fill out both the api key and site url
    • Try using both IP-based spam detection in both on and off modes
  • Put a debug break point into: server/src/core/server/services/comments/pipeline/phases/spam.ts at Line 111
  • Post comments
    • Can try using some spam comment examples from around the internet if you'd like
  • See it processing the isSpam state for the comments

Where any tests migrated to React Testing Library?

No

How do we deploy this PR?

No special considerations.

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 22cebb9
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65667898fa07c90008f13d33

@nick-funk nick-funk changed the title Upgrade akismet-api and use new payload types for spam checks Upgrade akismet-api and use new payload types for spam checks Nov 28, 2023
@Sentynel
Copy link
Contributor

Can I ask what future work is planned for the Akismet integration?

@nick-funk nick-funk added this pull request to the merge queue Jan 11, 2024
Merged via the queue into develop with commit ca36016 Jan 11, 2024
5 checks passed
@nick-funk nick-funk deleted the fix/akismet-spam-improvements branch January 11, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants