Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation for comment rejection reason when user is banned #4444

Closed
wants to merge 1 commit into from

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Dec 5, 2023

What does this PR do?

The translation string used in the case of comments being rejected when a user is banned is now sent through in the correct order and found in the correct translation file, as well.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can ban a user. Then check the moderate card for the comment(s) rejected when they were banned in the admin and see that it says "User was banned." under detailed explanation and not "common-userBanned".

Where any tests migrated to React Testing Library?

How do we deploy this PR?

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 36173ea
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/656f2e9d01ffc10008d55eb6

@kabeaty
Copy link
Contributor Author

kabeaty commented Dec 12, 2023

Closing this PR to handle here #4455

@kabeaty kabeaty closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant