Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 18 (Testing GHA CI pipelines) #4451

Merged
merged 7 commits into from
Jan 2, 2024

Conversation

nick-funk
Copy link
Contributor

@nick-funk nick-funk commented Dec 8, 2023

What does this PR do?

  • Re-enables the reverted commit with the Node 18 changes

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

N/A

How do I test this PR?

  • Pull down branch
  • Perform a production build using node 18.16.0 and npm 8.0.0
  • See that the build completes
    • Feel free to test Coral functionality too
  • See that GHA build for this branch has also completed

Were any tests migrated to React Testing Library?

No

How do we deploy this PR?

  • Merge into develop and target for another release
    • May want to release this on its own as its own release as it is upgrading all of node from v14 to v18

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 096e601
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65946ebc216fa90008b55f33

@nick-funk nick-funk requested a review from kabeaty December 8, 2023 17:01
@nick-funk nick-funk enabled auto-merge January 2, 2024 20:33
@nick-funk nick-funk added this pull request to the merge queue Jan 2, 2024
Merged via the queue into develop with commit fb16b73 Jan 2, 2024
6 checks passed
@nick-funk nick-funk deleted the feat/upgrade-to-node-18-ci branch January 2, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants