[CORL-3008] when auth token is invalid, clear it and reload the stream #4472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
kabeaty
approved these changes
Jan 2, 2024
| @@ -111,6 +111,8 @@ interface CreateContextArguments { | |||
| * of the render window | |||
| */ | |||
| customScrollContainer?: HTMLElement; | |||
|
|
|||
| onAuthError?: () => void; | |||
There was a problem hiding this comment.
Can you please add a comment here explaining onAuthError, consistent with other args?
| @@ -99,6 +102,13 @@ export async function attach(options: AttachOptions) { | |||
| await new Promise((resolve) => options.refreshAccessToken!(resolve)); | |||
| } | |||
|
|
|||
| const onContextAuthError = async () => { | |||
| const localStorage = resolveStorage("localStorage"); | |||
| await localStorage.removeItem("v2:accessToken"); | |||
There was a problem hiding this comment.
Can this be updated to also use the ACCESS_TOKEN_KEY already defined in client framework?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes it so that the stream clears the user's auth token when it is invalid or expired and reloads the stream so they can view comments, log in again, and continue using Coral.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
None
Does this PR introduce any new environment variables or feature flags?
No
If any indexes were added, were they added to
INDEXES.md?No new indices
How do I test this PR?
npm run watchon both server and clienthttp://localhost:8080with a user accountcoraldatabase in Mongonpm run start:developmenthttp://localhost:3000/installnpm run watchfor the serverhttp://localhost:8080coral:v2:accessTokenstorage key and the stream shows up in the signed out stateWere any tests migrated to React Testing Library?
No
How do we deploy this PR?
No special considerations.