Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-3021]: Update Twitter to X #4482

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Jan 11, 2024

What does this PR do?

These updates change mentions of Twitter to X.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

Go to the admin. See that under General --> Embedded media, it now says X post in the overall configuration description and regarding enable X post embeds. Make sure X post embeds are enabled.

Go to the stream. Paste an X post url. See that you are prompted with Add this post to the end of your comment? and the X logo. Click Add post. See that the post is added to your comment.

Also check that the wording in user preferences around showing/hiding media (including posts) is updated now.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit a40d168
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65a03d67e8b8510008993c4d

@kabeaty kabeaty requested a review from nick-funk January 11, 2024 19:11
Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kabeaty kabeaty added this pull request to the merge queue Jan 23, 2024
Merged via the queue into develop with commit bad82f2 Jan 23, 2024
6 checks passed
@kabeaty kabeaty deleted the feat/CORL-3021-update-twitter-to-x branch January 23, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants