Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-3042]: update detailed explanation copy in rejection modal #4488

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Jan 18, 2024

What does this PR do?

Updates the detailed explanation copy to clarify it's shared with the commenter in the rejection modal in the admin, not decision reason info.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

Does this PR introduce any new environment variables or feature flags?

If any indexes were added, were they added to INDEXES.md?

How do I test this PR?

See the correct copy (Detailed explanation (shared with commenter)) in the rejection modal when rejecting a comment in the admin. Also see the correct copy (just Detailed explanation when a detailed rejection explanation is shown in the moderate card.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit fddd66f
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65a92c2fa5d3b0000849e7c9

@kabeaty kabeaty requested a review from nick-funk January 18, 2024 13:48
Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nick-funk nick-funk added this pull request to the merge queue Jan 18, 2024
Merged via the queue into develop with commit 8a4f02b Jan 18, 2024
6 checks passed
@nick-funk nick-funk deleted the fix/8.7.1-rejection-reason-shared-copy branch January 18, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants